Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Append clientId to tag, remove button to make them unique #324

Closed
wants to merge 1 commit into from
Closed

fix: Append clientId to tag, remove button to make them unique #324

wants to merge 1 commit into from

Conversation

mrchief
Copy link
Collaborator

@mrchief mrchief commented Jan 19, 2020

Currently, having multiple component instances on same page renders same remove-button, tag ids.

Fixes #315

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [n/a] Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@mrchief
fix: Append clientId to tag, remove button to make them unique
917ed28 
Currently, having multiple component instances on same page renders same remove-button, tag ids.

Fixes #315
@codeclimate
Copy link

codeclimate bot commented Jan 19, 2020

Code Climate has analyzed commit 917ed28 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1332

  • 12 of 12 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.23%
Totals Coverage Status
Change from base Build 1328: 0.0%
Covered Lines: 585
Relevant Lines: 598
💛 - Coveralls

@mrchief
Copy link
Collaborator Author

mrchief commented Jan 19, 2020

Not needed. #315 had custom data which resulted in the issue. The component already appends clientId to each constituent component.

@mrchief mrchief closed this Jan 19, 2020
@mrchief mrchief deleted the fix/dedup-remove-button-id branch January 19, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"x" buttons have same id in HTML DOM
2 participants
@mrchief @coveralls